Add a scheduled run for hermes. #3822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitrisJim
force-pushed
the
hermes_cron_job
branch
from
e026b25
to
725d34e
Compare
DimitrisJim
force-pushed
the
hermes_cron_job
branch
from
725d34e
to
150e223
Compare
DimitrisJim
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan and
chatton
as code owners
DimitrisJim
commented
Jun 13, 2023
| @@ -1,5 +1,14 @@ | |||
| # The Tests / E2E workflow is used to run end-to-end tests on pull requests originating | |||
There was a problem hiding this comment.
I think it makes more sense to add the change to run hermes here instead of duplicating all of the workflow
DimitrisJim
commented
Jun 13, 2023
| # by a scheduled run or not. | ||
| - id: get-relayer | ||
| run: | | ||
| if [ "${{ github.event_name }}" == "schedule" ] |
There was a problem hiding this comment.
if the event is schedule we set hermes as the relayer, if not rly is set.
DimitrisJim
commented
Jun 13, 2023
| @@ -80,3 +98,4 @@ jobs: | |||
| chain-binary: 'simd' | |||
| # on regular PRs we won't run interchain account or upgrade tests. | |||
| test-exclusions: 'TestInterTxTestSuite,TestIncentivizedInterTxTestSuite,TestUpgradeTestSuite' | |||
| relayer-tag: "${{ needs.determine-image-tag.outputs.relayer }}" | |||
There was a problem hiding this comment.
pass as input to the workflow.
chatton
approved these changes
Jun 14, 2023
damiannolan
approved these changes
Jun 14, 2023
|
Yeah, I currently will get notified as the last user to touch the workflow. It might make sense to also include the |
3 tasks
3 tasks
|
Opened #3842 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I believe this should easily cover us. Sets a schedule for every night to run hermes.
closes: #3779
Commit Message / Changelog Entry
chore: add a scheduled run for hermes.see the guidelines for commit messages. (view raw markdown for examples)
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/).godoccomments.Files changedin the Github PR explorer.Codecov Reportin the comment section below once CI passes.